Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue that github action windows build could not find win10sdk #6726

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix issue that github action windows build could not find win10sdk #6726

merged 3 commits into from
Sep 11, 2024

Conversation

Noisyfox
Copy link
Collaborator

Fix #6724

@Noisyfox Noisyfox marked this pull request as draft September 11, 2024 01:48
@Noisyfox Noisyfox marked this pull request as ready for review September 11, 2024 01:56
@Noisyfox
Copy link
Collaborator Author

image

SoftFever
SoftFever reviewed Sep 11, 2024
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert those changes in build_release_vs2022.bat instead? It seems people might encounter issues if they build Orca from a standard PowerShell or CMD environment locally.

@Noisyfox
Copy link
Collaborator Author

Should we revert those changes in build_release_vs2022.bat instead? It seems people might encounter issues if they build Orca from a standard PowerShell or CMD environment locally.

Well I actually like the current build_release_vs2022.bat because I have unusual win10sdk installation path & version, and I used to have to change it everytime I want to build, but now I don't need to do that anymore.

@SoftFever
Copy link
Owner

Make sense.
I'm fine with the current change then.

Thank you!

@SoftFever SoftFever merged commit 5c3e094 into SoftFever:main Sep 11, 2024
15 checks passed
@Noisyfox Noisyfox deleted the bugfox/windows-fix-model branch September 11, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Model Missing from Nightly OrcaSlicer_Windows_Installer_V2.2.0-beta.exe
2 participants
@Noisyfox @SoftFever